void/AyuGramDesktop
2
0
Fork 0
mirror of https://github.com/AyuGram/AyuGramDesktop.git synced 2025-06-05 06:33:57 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix a crash in forwarded sender avatars.

Browse source
This commit is contained in:
John Preston 2024-06-03 22:59:14 +04:00
parent 9043c18725
commit 06d0e78b00
1 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
Telegram/SourceFiles/history/history_item_components.cpp
View file

@ -196,14 +196,19 @@ void HistoryMessageForwarded::create(
? originalSender->name() ? originalSender->name()
: originalHiddenSenderInfo->name) : originalHiddenSenderInfo->name)
}; };
if (originalSender) { if (const auto copy = originalSender) {
context.session = &originalSender->owner().session(); context.session = &copy->owner().session();
context.customEmojiRepaint = [=] { context.customEmojiRepaint = [=] {
originalSender->owner().requestItemRepaint(item); // It is important to capture here originalSender by value,
// not capture the HistoryMessageForwarded* and read the
// originalSender field, because the components themselves
// get moved from place to place and the captured `this`
// pointer may become invalid, resulting in a crash.
copy->owner().requestItemRepaint(item);
}; };
phrase = Ui::Text::SingleCustomEmoji( phrase = Ui::Text::SingleCustomEmoji(
context.session->data().customEmojiManager().peerUserpicEmojiData( context.session->data().customEmojiManager().peerUserpicEmojiData(
originalSender, copy,
st::fwdTextUserpicPadding)); st::fwdTextUserpicPadding));
} }
if (!originalPostAuthor.isEmpty()) { if (!originalPostAuthor.isEmpty()) {