fix: AyuForward crashes

Telegram/SourceFiles/ayu/features/forward/ayu_forward.cpp

@@ -99,8 +99,11 @@ std::pair<QString, QString> stateName(const PeerId &id) {
 
 void ForwardState::updateBottomBar(const Main::Session &session, const PeerId *peer, const State &st) {
 	state = st;
-
+	auto peerCopy = *peer;
-	session.changes().peerUpdated(session.data().peer(*peer), Data::PeerUpdate::Flag::Rights);
+	crl::on_main([&, peerCopy]
+	{
+		session.changes().peerUpdated(session.data().peer(peerCopy), Data::PeerUpdate::Flag::Rights);
+	});
 }
 
 static Ui::PreparedList prepareMedia(not_null<Main::Session*> session,
@@ -111,6 +114,10 @@ static Ui::PreparedList prepareMedia(not_null<Main::Session*> session,
 	{
 		groupMedia.emplace_back(media);
 		auto prepared = Ui::PreparedFile(AyuSync::filePath(session, media));
+		if (prepared.path.isEmpty()) {
+			// otherwise will fail assertion in PrepareDetails
+			return prepared;
+		}
 		Storage::PrepareDetails(prepared, st::sendMediaPreviewSize, PhotoSideLimit());
 		return prepared;
 	};
@@ -120,7 +127,9 @@ static Ui::PreparedList prepareMedia(not_null<Main::Session*> session,
 	const auto groupId = startItem->groupId();
 
 	Ui::PreparedList list;
-	list.files.emplace_back(prepare(media));
+	if (auto prepared = prepare(media); !prepared.path.isEmpty()) {
+		list.files.emplace_back(std::move(prepared));
+	}
 
 	if (!groupId.value) {
 		return list;
@@ -132,7 +141,9 @@ static Ui::PreparedList prepareMedia(not_null<Main::Session*> session,
 			break;
 		}
 		if (const auto nextMedia = nextItem->media()) {
-			list.files.emplace_back(prepare(nextMedia));
+			if (auto prepared = prepare(nextMedia); !prepared.path.isEmpty()) {
+				list.files.emplace_back(std::move(prepared));
+			}
 			i = k;
 		}
 	}
@@ -296,7 +307,10 @@ void forwardMessages(
 	const auto history = action.history;
 	const auto peer = history->peer;
 
+	crl::on_main([&]
+	{
 		history->setForwardDraft(action.replyTo.topicRootId, action.replyTo.monoforumPeerId, {});
+	});
 
 	std::shared_ptr<ForwardState> state;
 

Telegram/SourceFiles/ayu/features/forward/ayu_sync.cpp

@@ -5,8 +5,9 @@
 //
 // Copyright @Radolyn, 2025
 #include "ayu_sync.h"
-#include "apiwrap.h"
 #include "api/api_sending.h"
+#include "apiwrap.h"
+#include "ayu/utils/telegram_helpers.h"
 #include "core/application.h"
 #include "core/core_settings.h"
 #include "core/file_utilities.h"
@@ -127,6 +128,8 @@ void loadDocumentSync(not_null<Main::Session*> session, DocumentData *data, not_
 	auto latch = std::make_shared<TimedCountDownLatch>(1);
 	auto lifetime = std::make_shared<rpl::lifetime>();
 
+	crl::on_main([&]
+	{
 		data->save(Data::FileOriginMessage(item->fullId()), filePath(session, item->media()));
 
 		rpl::single() | rpl::then(
@@ -140,6 +143,7 @@ void loadDocumentSync(not_null<Main::Session*> session, DocumentData *data, not_
 									  base::take(lifetime)->destroy();
 								  },
 								  *lifetime);
+	});
 
 	latch->await(std::chrono::minutes(5));
 }
@@ -207,6 +211,8 @@ void loadPhotoSync(not_null<Main::Session*> session, const std::pair<not_null<Ph
 	if (finalCheck()) {
 		saveToFiles();
 	} else {
+		crl::on_main([&]
+		{
 			session->downloaderTaskFinished() | rpl::filter([&]
 			{
 				return finalCheck();
@@ -217,10 +223,10 @@ void loadPhotoSync(not_null<Main::Session*> session, const std::pair<not_null<Ph
 										  base::take(lifetime)->destroy();
 									  },
 									  *lifetime);
-	}
+		});
-
 		latch->await(std::chrono::minutes(5));
 	}
+}
 
 void sendMessageSync(not_null<Main::Session*> session, Api::MessageToSend &message) {
 	crl::on_main([=, &message]
@@ -240,7 +246,8 @@ void waitForMsgSync(not_null<Main::Session*> session, const Api::SendAction &act
 	auto latch = std::make_shared<TimedCountDownLatch>(1);
 	auto lifetime = std::make_shared<rpl::lifetime>();
 
-
+	crl::on_main([&]
+	{
 		session->data().itemIdChanged()
 			| rpl::filter([&](const Data::Session::IdChange &update)
 			{
@@ -251,6 +258,7 @@ void waitForMsgSync(not_null<Main::Session*> session, const Api::SendAction &act
 										  base::take(lifetime)->destroy();
 									  },
 									  *lifetime);
+	});
 
 	latch->await(std::chrono::minutes(2));
 }
@@ -260,9 +268,6 @@ void sendDocumentSync(not_null<Main::Session*> session,
 					  SendMediaType type,
 					  TextWithTags &&caption,
 					  const Api::SendAction &action) {
-	const auto size = group.list.files.size();
-	auto latch = std::make_shared<TimedCountDownLatch>(size);
-	auto lifetime = std::make_shared<rpl::lifetime>();
 
 	auto groupId = std::make_shared<SendingAlbum>();
 	groupId->groupId = base::RandomValue<uint64>();
@@ -272,27 +277,7 @@ void sendDocumentSync(not_null<Main::Session*> session,
 		session->api().sendFiles(std::move(lst), type, std::move(caption), groupId, action);
 	});
 
-
+	waitForMsgSync(session, action);
-	// probably need to handle
-	// session->uploader().photoFailed()
-	// and
-	// session->uploader().documentFailed()
-	// too
-
-	rpl::merge(
-		session->uploader().documentReady(),
-		session->uploader().photoReady()
-	) | rpl::filter([&](const Storage::UploadedMedia &docOrPhoto)
-	{
-		return docOrPhoto.fullId.peer == action.history->peer->id;
-	}) | rpl::start_with_next([&]
-							  {
-								  latch->countDown();
-							  },
-							  *lifetime);
-
-	latch->await(std::chrono::minutes(5 * size));
-	base::take(lifetime)->destroy();
 }
 
 void sendStickerSync(not_null<Main::Session*> session,