void/AyuGramDesktop
2
0
Fork 0
mirror of https://github.com/AyuGram/AyuGramDesktop.git synced 2025-07-26 23:43:06 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix possible stack overflow in subsection tabs.

Browse source
This commit is contained in:
John Preston 2025-06-04 17:59:10 +04:00
parent 66473738d6
commit 158d2a4124
1 changed files with 25 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
Telegram/SourceFiles/history/view/history_view_subsection_tabs.cpp
View file

@ -231,18 +231,40 @@ void SubsectionTabs::setupSlider(
: scroll->scrollLeftMax(); : scroll->scrollLeftMax();
const auto availableFrom = scrollValue; const auto availableFrom = scrollValue;
const auto availableTill = (scrollMax - scrollValue); const auto availableTill = (scrollMax - scrollValue);
if (scrollMax <= 2 * full && _afterAvailable > 0) { if (scrollMax <= 3 * full && _afterAvailable > 0) {
_beforeLimit *= 2; _beforeLimit *= 2;
_afterLimit *= 2; _afterLimit *= 2;
} }
const auto findMiddle = [&] {
Expects(!_slice.empty());
auto best = -1;
auto bestDistance = -1;
const auto ideal = scrollValue + (full / 2);
for (auto i = 0, count = int(_slice.size()); i != count; ++i) {
const auto a = slider->lookupSectionPosition(i);
const auto b = (i + 1 == count)
? (full + scrollMax)
: slider->lookupSectionPosition(i + 1);
const auto middle = (a + b) / 2;
const auto distance = std::abs(middle - ideal);
if (best < 0 || distance < bestDistance) {
best = i;
bestDistance = distance;
}
}
Ensures(best >= 0);
return best;
};
if (availableFrom < full if (availableFrom < full
&& _beforeSkipped.value_or(0) > 0 && _beforeSkipped.value_or(0) > 0
&& !_slice.empty()) { && !_slice.empty()) {
_around = _slice.front().thread; _around = _slice[findMiddle()].thread;
refreshSlice(); refreshSlice();
} else if (availableTill < full) { } else if (availableTill < full) {
if (_afterAvailable > 0) { if (_afterAvailable > 0) {
_around = _slice.back().thread; _around = _slice[findMiddle()].thread;
refreshSlice(); refreshSlice();
} else if (!_afterSkipped.has_value()) { } else if (!_afterSkipped.has_value()) {
_loading = true; _loading = true;