Removed MTP* from public interface of Api::CloudPassword.

Telegram/SourceFiles/api/api_cloud_password.cpp

@@ -41,24 +41,6 @@ void CloudPassword::reload() {
 	}).send();
 }
 
-void CloudPassword::applyPendingReset(
-		const MTPaccount_ResetPasswordResult &data) {
-	if (!_state) {
-		reload();
-		return;
-	}
-	data.match([&](const MTPDaccount_resetPasswordOk &data) {
-		reload();
-	}, [&](const MTPDaccount_resetPasswordRequestedWait &data) {
-		const auto until = data.vuntil_date().v;
-		if (_state->pendingResetDate != until) {
-			_state->pendingResetDate = until;
-			_stateChanges.fire_copy(*_state);
-		}
-	}, [&](const MTPDaccount_resetPasswordFailedWait &data) {
-	});
-}
-
 void CloudPassword::clearUnconfirmedPassword() {
 	_requestId = _api.request(MTPaccount_CancelPasswordEmail(
 	)).done([=](const MTPBool &result) {
@@ -83,4 +65,48 @@ auto CloudPassword::stateCurrent() const
 		: std::nullopt;
 }
 
+auto CloudPassword::resetPassword()
+-> rpl::producer<CloudPassword::ResetRetryDate, QString> {
+	return [=](auto consumer) {
+		_api.request(MTPaccount_ResetPassword(
+		)).done([=](const MTPaccount_ResetPasswordResult &result) {
+			result.match([&](const MTPDaccount_resetPasswordOk &data) {
+				reload();
+			}, [&](const MTPDaccount_resetPasswordRequestedWait &data) {
+				if (!_state) {
+					reload();
+					return;
+				}
+				const auto until = data.vuntil_date().v;
+				if (_state->pendingResetDate != until) {
+					_state->pendingResetDate = until;
+					_stateChanges.fire_copy(*_state);
+				}
+			}, [&](const MTPDaccount_resetPasswordFailedWait &data) {
+				consumer.put_next_copy(data.vretry_date().v);
+			});
+			consumer.put_done();
+		}).fail([=](const MTP::Error &error) {
+			consumer.put_error_copy(error.type());
+		}).send();
+
+		return rpl::lifetime();
+	};
+}
+
+auto CloudPassword::cancelResetPassword()
+-> rpl::producer<rpl::no_value, QString> {
+	return [=](auto consumer) {
+		_api.request(MTPaccount_DeclinePasswordReset(
+		)).done([=] {
+			reload();
+			consumer.put_done();
+		}).fail([=](const MTP::Error &error) {
+			consumer.put_error_copy(error.type());
+		}).send();
+
+		return rpl::lifetime();
+	};
+}
+
 } // namespace Api

Telegram/SourceFiles/api/api_cloud_password.h

@@ -23,14 +23,17 @@ namespace Api {
 
 class CloudPassword final {
 public:
+	using ResetRetryDate = int;
 	explicit CloudPassword(not_null<ApiWrap*> api);
 
 	void reload();
-	void applyPendingReset(const MTPaccount_ResetPasswordResult &data);
 	void clearUnconfirmedPassword();
 	rpl::producer<Core::CloudPasswordState> state() const;
 	std::optional<Core::CloudPasswordState> stateCurrent() const;
 
+	rpl::producer<ResetRetryDate, QString> resetPassword();
+	rpl::producer<rpl::no_value, QString> cancelResetPassword();
+
 private:
 	MTP::Sender _api;
 	mtpRequestId _requestId = 0;

Telegram/SourceFiles/boxes/passcode_box.cpp

@@ -102,49 +102,53 @@ void StartPendingReset(
 		not_null<Ui::BoxContent*> context,
 		Fn<void()> close) {
 	const auto weak = Ui::MakeWeak(context.get());
-	session->api().request(MTPaccount_ResetPassword(
+	auto lifetime = std::make_shared<rpl::lifetime>();
-	)).done([=](const MTPaccount_ResetPasswordResult &result) {
+
-		session->api().cloudPassword().applyPendingReset(result);
+	auto finish = [=](const QString &message) mutable {
-		result.match([&](const MTPDaccount_resetPasswordOk &data) {
+		if (const auto strong = weak.data()) {
-		}, [&](const MTPDaccount_resetPasswordRequestedWait &data) {
+			if (!message.isEmpty()) {
-		}, [&](const MTPDaccount_resetPasswordFailedWait &data) {
+				strong->getDelegate()->show(Box<InformBox>(message));
-			constexpr auto kMinute = 60;
-			constexpr auto kHour = 3600;
-			constexpr auto kDay = 86400;
-			const auto left = std::max(
-				data.vretry_date().v - base::unixtime::now(),
-				kMinute);
-			const auto days = (left / kDay);
-			const auto hours = (left / kHour);
-			const auto minutes = (left / kMinute);
-			const auto duration = days
-				? tr::lng_group_call_duration_days(tr::now, lt_count, days)
-				: hours
-				? tr::lng_group_call_duration_hours(tr::now, lt_count, hours)
-				: tr::lng_group_call_duration_minutes(
-					tr::now,
-					lt_count,
-					minutes);
-			if (const auto strong = weak.data()) {
-				strong->getDelegate()->show(Box<InformBox>(
-					tr::lng_cloud_password_reset_later(
-						tr::now,
-						lt_duration,
-						duration)));
 			}
-		});
-		if (const auto strong = weak.data()) {
 			strong->closeBox();
 		}
 		close();
-	}).fail([=](const MTP::Error &error) {
+		if (lifetime) {
-		if (const auto strong = weak.data()) {
+			base::take(lifetime)->destroy();
-			strong->getDelegate()->show(
-				Box<InformBox>("Error: " + error.type()));
-			strong->closeBox();
 		}
-		close();
+	};
-	}).send();
+
+	session->api().cloudPassword().resetPassword(
+	) | rpl::start_with_next_error_done([=](
+			Api::CloudPassword::ResetRetryDate retryDate) {
+		constexpr auto kMinute = 60;
+		constexpr auto kHour = 3600;
+		constexpr auto kDay = 86400;
+		const auto left = std::max(
+			retryDate - base::unixtime::now(),
+			kMinute);
+		const auto days = (left / kDay);
+		const auto hours = (left / kHour);
+		const auto minutes = (left / kMinute);
+		const auto duration = days
+			? tr::lng_group_call_duration_days(tr::now, lt_count, days)
+			: hours
+			? tr::lng_group_call_duration_hours(tr::now, lt_count, hours)
+			: tr::lng_group_call_duration_minutes(
+				tr::now,
+				lt_count,
+				minutes);
+		if (const auto strong = weak.data()) {
+			strong->getDelegate()->show(Box<InformBox>(
+				tr::lng_cloud_password_reset_later(
+					tr::now,
+					lt_duration,
+					duration)));
+		}
+	}, [=](const QString &error) mutable {
+		finish("Error: " + error);
+	}, [=]() mutable {
+		finish({});
+	}, *lifetime);
 }
 
 } // namespace

Telegram/SourceFiles/settings/settings_privacy_security.cpp

@@ -558,7 +558,7 @@ void SetupCloudPassword(
 	) | rpl::map([](TimeId time) {
 		return time != 0;
 	}));
-	const auto sent = std::make_shared<mtpRequestId>(0);
+	const auto sent = std::make_shared<bool>(false);
 	reset->entity()->addClickHandler([=] {
 		const auto api = &session->api();
 		const auto state = api->cloudPassword().stateCurrent();
@@ -566,23 +566,23 @@ void SetupCloudPassword(
 		if (!date || *sent) {
 			return;
 		} else if (base::unixtime::now() >= date) {
-			*sent = api->request(MTPaccount_ResetPassword(
+			*sent = true;
-			)).done([=](const MTPaccount_ResetPasswordResult &result) {
+			api->cloudPassword().resetPassword(
-				*sent = 0;
+			) | rpl::start_with_error_done([=](const QString &error) {
-				api->cloudPassword().applyPendingReset(result);
+				*sent = false;
-			}).fail([=](const MTP::Error &error) {
+			}, [=] {
-				*sent = 0;
+				*sent = false;
-			}).send();
+			}, container->lifetime());
 		} else {
 			const auto cancel = [=] {
 				Ui::hideLayer();
-				*sent = api->request(MTPaccount_DeclinePasswordReset(
+				*sent = true;
-				)).done([=] {
+				api->cloudPassword().cancelResetPassword(
-					*sent = 0;
+				) | rpl::start_with_error_done([=](const QString &error) {
-					api->cloudPassword().reload();
+					*sent = false;
-				}).fail([=](const MTP::Error &error) {
+				}, [=] {
-					*sent = 0;
+					*sent = false;
-				}).send();
+				}, container->lifetime());
 			};
 			Ui::show(Box<ConfirmBox>(
 				tr::lng_cloud_password_reset_cancel_sure(tr::now),