void/AyuGramDesktop
2
0
Fork 0
mirror of https://github.com/AyuGram/AyuGramDesktop.git synced 2025-06-05 06:33:57 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix rare crash in message history resizing.

Browse source
This commit is contained in:
John Preston 2021-09-01 19:21:39 +03:00
parent a064e836f2
commit 5aff4cca0e
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
Telegram/SourceFiles/history/history_widget.cpp
View file

@ -5018,6 +5018,8 @@ void HistoryWidget::startItemRevealAnimations() {
} }
void HistoryWidget::updateListSize() { void HistoryWidget::updateListSize() {
Expects(_list != nullptr);
_list->recountHistoryGeometry(); _list->recountHistoryGeometry();
auto washidden = _scroll->isHidden(); auto washidden = _scroll->isHidden();
if (washidden) { if (washidden) {
@ -5033,6 +5035,16 @@ void HistoryWidget::updateListSize() {
} }
bool HistoryWidget::hasPendingResizedItems() const { bool HistoryWidget::hasPendingResizedItems() const {
if (!_list) {
// Based on the crash reports there is a codepath (at least on macOS)
// that leads from _list = _scroll->setOwnedWidget(...) right into
// the HistoryWidget::paintEvent (by sending fake mouse move events
// inside scroll area -> hiding tooltip window -> exposing the main
// window -> syncing it backing store synchronously).
//
// So really we could get here with !_list && (_history != nullptr).
return false;
}
return (_history && _history->hasPendingResizedItems()) return (_history && _history->hasPendingResizedItems())
|| (_migrated && _migrated->hasPendingResizedItems()); || (_migrated && _migrated->hasPendingResizedItems());
} }