From 80597e190acbd9b74993d67743c406b772156454 Mon Sep 17 00:00:00 2001
From: 23rd <23rd@vivaldi.net>
Date: Mon, 30 Nov 2020 23:56:43 +0300
Subject: [PATCH] Fixed permissions requesting for different call types.

---
 Telegram/SourceFiles/calls/calls_call.cpp     | 11 ++++++++++-
 Telegram/SourceFiles/calls/calls_call.h       |  5 ++++-
 Telegram/SourceFiles/calls/calls_instance.cpp | 17 ++++++++++-------
 Telegram/SourceFiles/calls/calls_instance.h   |  8 +++++---
 Telegram/SourceFiles/calls/calls_panel.cpp    |  5 +----
 5 files changed, 30 insertions(+), 16 deletions(-)

diff --git a/Telegram/SourceFiles/calls/calls_call.cpp b/Telegram/SourceFiles/calls/calls_call.cpp
index 9b428d407..913536660 100644
--- a/Telegram/SourceFiles/calls/calls_call.cpp
+++ b/Telegram/SourceFiles/calls/calls_call.cpp
@@ -288,10 +288,19 @@ void Call::startIncoming() {
 	}).send();
 }
 
+void Call::switchVideoOutgoing() {
+	const auto video = _videoOutgoing->state() == Webrtc::VideoState::Active;
+	_delegate->callRequestPermissionsOrFail(crl::guard(this, [=] {
+		videoOutgoing()->setState(StartVideoState(!video));
+	}), true);
+
+}
+
 void Call::answer() {
+	const auto video = _videoOutgoing->state() == Webrtc::VideoState::Active;
 	_delegate->callRequestPermissionsOrFail(crl::guard(this, [=] {
 		actuallyAnswer();
-	}));
+	}), video);
 }
 
 void Call::actuallyAnswer() {
diff --git a/Telegram/SourceFiles/calls/calls_call.h b/Telegram/SourceFiles/calls/calls_call.h
index 004225ecc..531397c1d 100644
--- a/Telegram/SourceFiles/calls/calls_call.h
+++ b/Telegram/SourceFiles/calls/calls_call.h
@@ -68,7 +68,9 @@ public:
 			Ended,
 		};
 		virtual void playSound(Sound sound) = 0;
-		virtual void callRequestPermissionsOrFail(Fn<void()> onSuccess) = 0;
+		virtual void callRequestPermissionsOrFail(
+			Fn<void()> onSuccess,
+			bool video) = 0;
 		virtual auto getVideoCapture()
 			-> std::shared_ptr<tgcalls::VideoCaptureInterface> = 0;
 
@@ -165,6 +167,7 @@ public:
 	crl::time getDurationMs() const;
 	float64 getWaitingSoundPeakValue() const;
 
+	void switchVideoOutgoing();
 	void answer();
 	void hangup();
 	void redial();
diff --git a/Telegram/SourceFiles/calls/calls_instance.cpp b/Telegram/SourceFiles/calls/calls_instance.cpp
index 672d36e53..e5e9f9510 100644
--- a/Telegram/SourceFiles/calls/calls_instance.cpp
+++ b/Telegram/SourceFiles/calls/calls_instance.cpp
@@ -55,7 +55,7 @@ void Instance::startOutgoingCall(not_null<UserData*> user, bool video) {
 	}
 	requestPermissionsOrFail(crl::guard(this, [=] {
 		createCall(user, Call::Type::Outgoing, video);
-	}));
+	}), video);
 }
 
 void Instance::startGroupCall(not_null<ChannelData*> channel) {
@@ -64,7 +64,7 @@ void Instance::startGroupCall(not_null<ChannelData*> channel) {
 	}
 	requestPermissionsOrFail(crl::guard(this, [=] {
 		createGroupCall(channel, MTP_inputGroupCall(MTPlong(), MTPlong()));
-	}));
+	}), false);
 }
 
 void Instance::joinGroupCall(
@@ -75,7 +75,7 @@ void Instance::joinGroupCall(
 	}
 	requestPermissionsOrFail(crl::guard(this, [=] {
 		createGroupCall(channel, call);
-	}));
+	}), false);
 }
 
 void Instance::callFinished(not_null<Call*> call) {
@@ -462,12 +462,15 @@ rpl::producer<GroupCall*> Instance::currentGroupCallValue() const {
 	return _currentGroupCallChanges.events_starting_with(currentGroupCall());
 }
 
-void Instance::requestPermissionsOrFail(Fn<void()> onSuccess) {
+void Instance::requestPermissionsOrFail(Fn<void()> onSuccess, bool video) {
 	using Type = Platform::PermissionType;
 	requestPermissionOrFail(Type::Microphone, [=] {
-		requestPermissionOrFail(Type::Camera, [=] {
-			crl::on_main(onSuccess);
-		});
+		auto callback = [=] { crl::on_main(onSuccess); };
+		if (video) {
+			requestPermissionOrFail(Type::Camera, std::move(callback));
+		} else {
+			callback();
+		}
 	});
 }
 
diff --git a/Telegram/SourceFiles/calls/calls_instance.h b/Telegram/SourceFiles/calls/calls_instance.h
index 6877e1422..10d9b56b1 100644
--- a/Telegram/SourceFiles/calls/calls_instance.h
+++ b/Telegram/SourceFiles/calls/calls_instance.h
@@ -72,8 +72,10 @@ private:
 	void callFinished(not_null<Call*> call) override;
 	void callFailed(not_null<Call*> call) override;
 	void callRedial(not_null<Call*> call) override;
-	void callRequestPermissionsOrFail(Fn<void()> onSuccess) override {
-		requestPermissionsOrFail(std::move(onSuccess));
+	void callRequestPermissionsOrFail(
+			Fn<void()> onSuccess,
+			bool video) override {
+		requestPermissionsOrFail(std::move(onSuccess), video);
 	}
 
 	void groupCallFinished(not_null<GroupCall*> call) override;
@@ -89,7 +91,7 @@ private:
 		const MTPInputGroupCall &inputCall);
 	void destroyGroupCall(not_null<GroupCall*> call);
 
-	void requestPermissionsOrFail(Fn<void()> onSuccess);
+	void requestPermissionsOrFail(Fn<void()> onSuccess, bool video = true);
 	void requestPermissionOrFail(Platform::PermissionType type, Fn<void()> onSuccess);
 
 	void refreshDhConfig();
diff --git a/Telegram/SourceFiles/calls/calls_panel.cpp b/Telegram/SourceFiles/calls/calls_panel.cpp
index 14ac068f8..0d87b44c4 100644
--- a/Telegram/SourceFiles/calls/calls_panel.cpp
+++ b/Telegram/SourceFiles/calls/calls_panel.cpp
@@ -307,10 +307,7 @@ void Panel::initControls() {
 	});
 	_camera->setClickedCallback([=] {
 		if (_call) {
-			_call->videoOutgoing()->setState(
-				(_call->videoOutgoing()->state() == Webrtc::VideoState::Active)
-				? Webrtc::VideoState::Inactive
-				: Webrtc::VideoState::Active);
+			_call->switchVideoOutgoing();
 		}
 	});