From 86be105c2518f14b92eb74474771ee31fabcbb14 Mon Sep 17 00:00:00 2001 From: Ilya Fedin Date: Tue, 24 Nov 2020 23:17:57 +0400 Subject: [PATCH] Media Play key is expected to behave like Toggle Media Play/Pause Looks like Qt maps "Media Play" to the common play/pause button on keyboards: https://github.com/qt/qtbase/blob/5.15/src/platformsupport/input/xkbcommon/qxkbcommon.cpp#L293 https://github.com/qt/qtbase/blob/5.15/src/plugins/platforms/windows/qwindowskeymapper.cpp#L392 https://github.com/qt/qtbase/blob/5.15/src/plugins/platforms/android/androidjniinput.cpp#L519 https://github.com/qt/qtbase/blob/5.15/src/plugins/platforms/android/androidjniinput.cpp#L607 While "Toggle Media Play/Pause" is some special case: https://github.com/qt/qtbase/blob/5.15/src/plugins/platforms/windows/qwindowskeymapper.cpp#L488 https://github.com/qt/qtbase/blob/5.15/src/plugins/platforms/ios/quiview.mm#L584 It is worth to behave on "Media Play" like on "Toggle Media Play/Pause". --- Telegram/SourceFiles/media/player/media_player_instance.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Telegram/SourceFiles/media/player/media_player_instance.cpp b/Telegram/SourceFiles/media/player/media_player_instance.cpp index 7d3016df3d..f483ce0ece 100644 --- a/Telegram/SourceFiles/media/player/media_player_instance.cpp +++ b/Telegram/SourceFiles/media/player/media_player_instance.cpp @@ -737,7 +737,7 @@ void Instance::setupShortcuts() { ) | rpl::start_with_next([=](not_null request) { using Command = Shortcuts::Command; request->check(Command::MediaPlay) && request->handle([=] { - play(); + playPause(); return true; }); request->check(Command::MediaPause) && request->handle([=] {