void/AyuGramDesktop
2
0
Fork 0
mirror of https://github.com/AyuGram/AyuGramDesktop.git synced 2025-06-05 06:33:57 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Ensure temporaries don't detach with range loop

Browse source
This commit is contained in:
Ilya Fedin 2023-12-22 18:01:40 +04:00 • committed by John Preston
parent 26df482b54
commit fdef19a009
3 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Telegram/SourceFiles/mtproto/connection_http.cpp
View file

@ -55,7 +55,8 @@ void HttpConnection::disconnectFromServer() {
if (_status == Status::Finished) return; if (_status == Status::Finished) return;
_status = Status::Finished; _status = Status::Finished;
for (const auto request : base::take(_requests)) { const auto requests = base::take(_requests);
for (const auto request : requests) {
request->abort(); request->abort();
request->deleteLater(); request->deleteLater();
} }

3
Telegram/SourceFiles/mtproto/details/mtproto_domain_resolver.cpp
View file

@ -104,8 +104,9 @@ std::vector<DnsEntry> ParseDnsResponse(
return {}; return {};
} }
const auto array = (*answerIt).toArray();
auto result = std::vector<DnsEntry>(); auto result = std::vector<DnsEntry>();
for (const auto elem : (*answerIt).toArray()) { for (const auto elem : array) {
if (!elem.isObject()) { if (!elem.isObject()) {
LOG(("Config Error: Not an object found " LOG(("Config Error: Not an object found "
"in Answer array in dns response JSON.")); "in Answer array in dns response JSON."));

6
Telegram/SourceFiles/ui/chat/attach/attach_bot_webview.cpp
View file

@ -733,8 +733,9 @@ void Panel::switchInlineQueryMessage(const QJsonObject &args) {
u"groups"_q, u"groups"_q,
u"channels"_q, u"channels"_q,
}; };
const auto typeArray = args["chat_types"].toArray();
auto types = std::vector<QString>(); auto types = std::vector<QString>();
for (const auto &value : args["chat_types"].toArray()) { for (const auto &value : typeArray) {
const auto type = value.toString(); const auto type = value.toString();
if (valid.contains(type)) { if (valid.contains(type)) {
types.push_back(type); types.push_back(type);
@ -810,8 +811,9 @@ void Panel::openPopup(const QJsonObject &args) {
{ "cancel", Type::Cancel }, { "cancel", Type::Cancel },
{ "destructive", Type::Destructive }, { "destructive", Type::Destructive },
}; };
const auto buttonArray = args["buttons"].toArray();
auto buttons = std::vector<Webview::PopupArgs::Button>(); auto buttons = std::vector<Webview::PopupArgs::Button>();
for (const auto button : args["buttons"].toArray()) { for (const auto button : buttonArray) {
const auto fields = button.toObject(); const auto fields = button.toObject();
const auto i = types.find(fields["type"].toString()); const auto i = types.find(fields["type"].toString());
if (i == end(types)) { if (i == end(types)) {