From 1a72873ff6262f3d1171022dbddac4a86b1a8f5f Mon Sep 17 00:00:00 2001 From: mamoniot Date: Mon, 19 Dec 2022 10:37:04 -0500 Subject: [PATCH] added warning comment --- zssp/src/zssp.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/zssp/src/zssp.rs b/zssp/src/zssp.rs index 70de4ec65..2a96bf826 100644 --- a/zssp/src/zssp.rs +++ b/zssp/src/zssp.rs @@ -33,6 +33,8 @@ pub enum Error { InvalidParameter, /// Packet failed one or more authentication (MAC) checks + /// IMPORTANT: Do not reply to a peer who has sent a packet that has failed authentication. Any response at all will leak to an attacker what authentication step their packet failed at (timing attack), which lowers the total authentication entropy they have to brute force. + /// There is a safe way to reply if absolutely necessary, by sending the reply back after a constant amount of time, but this is difficult to get correct. FailedAuthentication, /// New session was rejected by the application layer.