From 3efb731b40372c5937f33a8feacdcbcd6bb4764f Mon Sep 17 00:00:00 2001 From: Grant Limberg Date: Thu, 8 Jun 2023 08:45:50 -0700 Subject: [PATCH] don't unborrow bad connections pool will clean them up later --- controller/PostgreSQL.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/controller/PostgreSQL.cpp b/controller/PostgreSQL.cpp index 1ec46e891..319c02684 100644 --- a/controller/PostgreSQL.cpp +++ b/controller/PostgreSQL.cpp @@ -527,9 +527,6 @@ AuthInfo PostgreSQL::getSSOAuthInfo(const nlohmann::json &member, const std::str _pool->unborrow(c); } catch (std::exception &e) { - if (c) { - _pool->unborrow(c); - } fprintf(stderr, "ERROR: Error updating member on load for network %s: %s\n", networkId.c_str(), e.what()); } @@ -1051,7 +1048,6 @@ void PostgreSQL::heartbeat() w.commit(); } catch (std::exception &e) { fprintf(stderr, "%s: Heartbeat update failed: %s\n", controllerId, e.what()); - _pool->unborrow(c); std::this_thread::sleep_for(std::chrono::milliseconds(1000)); continue; }