From c2d8fe46d58b1cbd87b6c87e599d688006d283c0 Mon Sep 17 00:00:00 2001
From: Adam Ierymenko <adam.ierymenko@zerotier.com>
Date: Fri, 23 Jul 2021 19:20:10 -0400
Subject: [PATCH] About ready to test notify of SSO timeout...

---
 controller/DBMirrorSet.cpp | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/controller/DBMirrorSet.cpp b/controller/DBMirrorSet.cpp
index 0bc16ce04..83998e3bc 100644
--- a/controller/DBMirrorSet.cpp
+++ b/controller/DBMirrorSet.cpp
@@ -246,10 +246,7 @@ std::set< std::pair<uint64_t, uint64_t> > DBMirrorSet::membersExpiringSoon()
 	std::unique_lock<std::mutex> l(_membersExpiringSoon_l);
 	int64_t now = OSUtils::now();
 	for(auto next=_membersExpiringSoon.begin();next!=_membersExpiringSoon.end();) {
-		if (next->first <= now) {
-			// Already expired, so the node will need to re-auth.
-			_membersExpiringSoon.erase(next++);
-		} else {
+		if (next->first > now) {
 			const uint64_t nwid = next->second.first;
 			const uint64_t memberId = next->second.second;
 			nlohmann::json network, member;
@@ -267,17 +264,15 @@ std::set< std::pair<uint64_t, uint64_t> > DBMirrorSet::membersExpiringSoon()
 						}
 					} else {
 						// Obsolete entry, no longer authorized, or SSO exempt.
-						_membersExpiringSoon.erase(next++);
 					}
 				} catch ( ... ) {
 					// Invalid member object, erase.
-					_membersExpiringSoon.erase(next++);
 				}
 			} else {
-				// Not found, so erase.
-				_membersExpiringSoon.erase(next++);
+				// Not found.
 			}
 		}
+		_membersExpiringSoon.erase(next++);
 	}
 	return soon;
 }