diff --git a/controller/PostgreSQL.cpp b/controller/PostgreSQL.cpp index 4c561974a..37d34dda9 100644 --- a/controller/PostgreSQL.cpp +++ b/controller/PostgreSQL.cpp @@ -1684,6 +1684,7 @@ void PostgreSQL::onlineNotification_Redis() while (_run == 1) { fprintf(stderr, "onlineNotification tick\n"); auto start = std::chrono::high_resolution_clock::now(); + uint64_t count = 0; std::unordered_map< std::pair,std::pair,_PairHasher > lastOnline; { @@ -1694,10 +1695,10 @@ void PostgreSQL::onlineNotification_Redis() if (!lastOnline.empty()) { if (_rc->clusterMode) { auto tx = _cluster->transaction(controllerId, true); - _doRedisUpdate(tx, controllerId, lastOnline); + count = _doRedisUpdate(tx, controllerId, lastOnline); } else { auto tx = _redis->transaction(true); - _doRedisUpdate(tx, controllerId, lastOnline); + count = _doRedisUpdate(tx, controllerId, lastOnline); } } } catch (sw::redis::Error &e) { @@ -1710,11 +1711,15 @@ void PostgreSQL::onlineNotification_Redis() fprintf(stderr, "onlineNotification ran in %llu ms\n", total); - std::this_thread::yield(); + if (count > 0) { + std::this_thread::yield(); + } else { + std::this_thread::sleep_for(std::chrono::seconds(1)); + } } } -void PostgreSQL::_doRedisUpdate(sw::redis::Transaction &tx, std::string &controllerId, +uint64_t PostgreSQL::_doRedisUpdate(sw::redis::Transaction &tx, std::string &controllerId, std::unordered_map< std::pair,std::pair,_PairHasher > &lastOnline) { @@ -1778,6 +1783,8 @@ void PostgreSQL::_doRedisUpdate(sw::redis::Transaction &tx, std::string &control } tx.exec(); fprintf(stderr, "%s: Updated online status of %d members\n", _myAddressStr.c_str(), count); + + return count; } diff --git a/controller/PostgreSQL.hpp b/controller/PostgreSQL.hpp index dfda7f698..c37c4e1a1 100644 --- a/controller/PostgreSQL.hpp +++ b/controller/PostgreSQL.hpp @@ -138,7 +138,7 @@ private: void onlineNotificationThread(); void onlineNotification_Postgres(); void onlineNotification_Redis(); - void _doRedisUpdate(sw::redis::Transaction &tx, std::string &controllerId, + uint64_t _doRedisUpdate(sw::redis::Transaction &tx, std::string &controllerId, std::unordered_map< std::pair,std::pair,_PairHasher > &lastOnline); enum OverrideMode {