fix: tests

This commit is contained in:
Mark Puha 2025-06-13 23:03:28 +02:00
parent a77df8158d
commit 33f1ee033c
3 changed files with 20 additions and 20 deletions

View file

@ -34,7 +34,7 @@ func Test_junkCreator_createJunkPackets(t *testing.T) {
return return
} }
t.Run("valid", func(t *testing.T) { t.Run("valid", func(t *testing.T) {
got := make([][]byte, jc.aSecCfg.JunkPacketCount) got := make([][]byte, 0, jc.aSecCfg.JunkPacketCount)
err := jc.CreateJunkPackets(&got) err := jc.CreateJunkPackets(&got)
if err != nil { if err != nil {
t.Errorf( t.Errorf(

View file

@ -52,10 +52,10 @@ func TestNewTagJunkGenerator(t *testing.T) {
tc := tc // capture range variable tc := tc // capture range variable
t.Run(tc.name, func(t *testing.T) { t.Run(tc.name, func(t *testing.T) {
t.Parallel() t.Parallel()
result := newTagJunkPacketGenerator(tc.genName, tc.size) result := newTagJunkPacketGenerator(tc.genName, "", tc.size)
require.Equal(t, tc.expected.name, result.name) require.Equal(t, tc.expected.name, result.name)
require.Equal(t, tc.expected.packetSize, result.packetSize) require.Equal(t, tc.expected.packetSize, result.packetSize)
require.Len(t, result.generators, len(tc.expected.generators)) require.Equal(t, cap(result.generators), len(tc.expected.generators))
}) })
} }
} }
@ -72,7 +72,7 @@ func TestTagJunkGeneratorAppend(t *testing.T) {
}{ }{
{ {
name: "Append to empty generator", name: "Append to empty generator",
initialState: newTagJunkPacketGenerator("T1", 0), initialState: newTagJunkPacketGenerator("T1", "", 0),
mockSize: 5, mockSize: 5,
expectedLength: 1, expectedLength: 1,
expectedSize: 5, expectedSize: 5,
@ -121,14 +121,14 @@ func TestTagJunkGeneratorGenerate(t *testing.T) {
{ {
name: "Generate with empty generators", name: "Generate with empty generators",
setupGenerator: func() TagJunkPacketGenerator { setupGenerator: func() TagJunkPacketGenerator {
return newTagJunkPacketGenerator("T1", 0) return newTagJunkPacketGenerator("T1", "", 0)
}, },
expected: []byte{}, expected: []byte{},
}, },
{ {
name: "Generate with single generator", name: "Generate with single generator",
setupGenerator: func() TagJunkPacketGenerator { setupGenerator: func() TagJunkPacketGenerator {
tg := newTagJunkPacketGenerator("T2", 0) tg := newTagJunkPacketGenerator("T2", "", 0)
tg.append(mockGen1) tg.append(mockGen1)
return tg return tg
}, },
@ -137,7 +137,7 @@ func TestTagJunkGeneratorGenerate(t *testing.T) {
{ {
name: "Generate with multiple generators", name: "Generate with multiple generators",
setupGenerator: func() TagJunkPacketGenerator { setupGenerator: func() TagJunkPacketGenerator {
tg := newTagJunkPacketGenerator("T3", 0) tg := newTagJunkPacketGenerator("T3", "", 0)
tg.append(mockGen1) tg.append(mockGen1)
tg.append(mockGen2) tg.append(mockGen2)
return tg return tg

View file

@ -14,7 +14,7 @@ func TestTagJunkGeneratorHandlerAppendGenerator(t *testing.T) {
}{ }{
{ {
name: "append single generator", name: "append single generator",
generator: newTagJunkPacketGenerator("t1", 10), generator: newTagJunkPacketGenerator("t1", "", 10),
}, },
} }
@ -47,8 +47,8 @@ func TestTagJunkGeneratorHandlerValidate(t *testing.T) {
{ {
name: "bad start", name: "bad start",
generators: []TagJunkPacketGenerator{ generators: []TagJunkPacketGenerator{
newTagJunkPacketGenerator("t3", 10), newTagJunkPacketGenerator("t3", "", 10),
newTagJunkPacketGenerator("t4", 10), newTagJunkPacketGenerator("t4", "", 10),
}, },
wantErr: true, wantErr: true,
errMsg: "junk packet index should be consecutive", errMsg: "junk packet index should be consecutive",
@ -56,8 +56,8 @@ func TestTagJunkGeneratorHandlerValidate(t *testing.T) {
{ {
name: "non-consecutive indices", name: "non-consecutive indices",
generators: []TagJunkPacketGenerator{ generators: []TagJunkPacketGenerator{
newTagJunkPacketGenerator("t1", 10), newTagJunkPacketGenerator("t1", "", 10),
newTagJunkPacketGenerator("t3", 10), // Missing t2 newTagJunkPacketGenerator("t3", "", 10), // Missing t2
}, },
wantErr: true, wantErr: true,
errMsg: "junk packet index should be consecutive", errMsg: "junk packet index should be consecutive",
@ -65,17 +65,17 @@ func TestTagJunkGeneratorHandlerValidate(t *testing.T) {
{ {
name: "consecutive indices", name: "consecutive indices",
generators: []TagJunkPacketGenerator{ generators: []TagJunkPacketGenerator{
newTagJunkPacketGenerator("t1", 10), newTagJunkPacketGenerator("t1", "", 10),
newTagJunkPacketGenerator("t2", 10), newTagJunkPacketGenerator("t2", "", 10),
newTagJunkPacketGenerator("t3", 10), newTagJunkPacketGenerator("t3", "", 10),
newTagJunkPacketGenerator("t4", 10), newTagJunkPacketGenerator("t4", "", 10),
newTagJunkPacketGenerator("t5", 10), newTagJunkPacketGenerator("t5", "", 10),
}, },
}, },
{ {
name: "nameIndex error", name: "nameIndex error",
generators: []TagJunkPacketGenerator{ generators: []TagJunkPacketGenerator{
newTagJunkPacketGenerator("error", 10), newTagJunkPacketGenerator("error", "", 10),
}, },
wantErr: true, wantErr: true,
errMsg: "name must be 2 character long", errMsg: "name must be 2 character long",
@ -116,10 +116,10 @@ func TestTagJunkGeneratorHandlerGenerate(t *testing.T) {
{ {
name: "generate with no default junk", name: "generate with no default junk",
setupGenerator: func() []TagJunkPacketGenerator { setupGenerator: func() []TagJunkPacketGenerator {
tg1 := newTagJunkPacketGenerator("t1", 0) tg1 := newTagJunkPacketGenerator("t1", "", 0)
tg1.append(mockGen1) tg1.append(mockGen1)
tg1.append(mockGen2) tg1.append(mockGen2)
tg2 := newTagJunkPacketGenerator("t2", 0) tg2 := newTagJunkPacketGenerator("t2", "", 0)
tg2.append(mockGen2) tg2.append(mockGen2)
tg2.append(mockGen1) tg2.append(mockGen1)