mirror of
https://github.com/trailofbits/algo.git
synced 2025-08-03 19:33:02 +02:00
* fix: Remove POSIX-incompatible 'local' keyword from install.sh The install.sh script uses #\!/usr/bin/env sh (POSIX shell) but was using the 'local' keyword in the tryGetMetadata function, which is a bash-specific feature. This caused shellcheck to fail with SC3043 warnings in CI. Fixed by removing 'local' keywords from variable declarations in the tryGetMetadata function. The variables are still function-scoped in practice since they're assigned at the beginning of the function. This resolves the CI failure introduced in PR #14788 (run #919). * ci: Make ansible-lint stricter and fix basic issues - Remove || true from ansible-lint CI job to enforce linting - Enable name[play] rule - all plays should be named - Enable yaml[new-line-at-end-of-file] rule - Move name[missing] from skip_list to warn_list (first step) - Add names to plays in main.yml and users.yml - Document future linting improvements in comments This makes the CI stricter while fixing the easy issues first. More comprehensive fixes for the 113 name[missing] warnings can be addressed in future PRs. * fix: Add name[missing] to skip_list temporarily The ansible-lint CI is failing because name[missing] was not properly added to skip_list. This causes 113 name[missing] errors to fail the CI. Adding it to skip_list for now to fix the CI. The rule can be moved to warn_list and eventually enabled once all tasks are properly named in future PRs. * fix: Fix ansible-lint critical errors - Fix schema[tasks] error in roles/local/tasks/prompts.yml by removing with_items loop - Add missing newline at end of requirements.yml - Replace ignore_errors with failed_when in reboot task - Add pipefail to shell command with pipes in strongswan openssl task These fixes address all critical ansible-lint errors that were causing CI failures.
266 lines
8.3 KiB
YAML
266 lines
8.3 KiB
YAML
---
|
|
- block:
|
|
- debug: var=subjectAltName
|
|
|
|
- name: Ensure the pki directory does not exist
|
|
file:
|
|
dest: "{{ ipsec_pki_path }}"
|
|
state: absent
|
|
when: keys_clean_all|bool
|
|
|
|
- name: Ensure the pki directories exist
|
|
file:
|
|
dest: "{{ ipsec_pki_path }}/{{ item }}"
|
|
state: directory
|
|
recurse: true
|
|
mode: "0700"
|
|
with_items:
|
|
- ecparams
|
|
- certs
|
|
- crl
|
|
- newcerts
|
|
- private
|
|
- public
|
|
- reqs
|
|
|
|
- name: Ensure the config directories exist
|
|
file:
|
|
dest: "{{ ipsec_config_path }}/{{ item }}"
|
|
state: directory
|
|
recurse: true
|
|
mode: "0700"
|
|
with_items:
|
|
- apple
|
|
- manual
|
|
|
|
- name: Ensure the files exist
|
|
file:
|
|
dest: "{{ ipsec_pki_path }}/{{ item }}"
|
|
state: touch
|
|
with_items:
|
|
- .rnd
|
|
- private/.rnd
|
|
- index.txt
|
|
- index.txt.attr
|
|
- serial
|
|
|
|
- name: Generate the openssl server configs
|
|
template:
|
|
src: openssl.cnf.j2
|
|
dest: "{{ ipsec_pki_path }}/openssl.cnf"
|
|
|
|
- name: Build the CA pair
|
|
shell: >
|
|
umask 077;
|
|
{{ openssl_bin }} ecparam -name secp384r1 -out ecparams/secp384r1.pem &&
|
|
{{ openssl_bin }} req -utf8 -new
|
|
-newkey ec:ecparams/secp384r1.pem
|
|
-config <(cat openssl.cnf <(printf "[basic_exts]\nsubjectAltName={{ subjectAltName }}"))
|
|
-keyout private/cakey.pem
|
|
-out cacert.pem -x509 -days 3650
|
|
-batch
|
|
-passout pass:"{{ CA_password }}" &&
|
|
touch {{ IP_subject_alt_name }}_ca_generated
|
|
args:
|
|
chdir: "{{ ipsec_pki_path }}"
|
|
creates: "{{ IP_subject_alt_name }}_ca_generated"
|
|
executable: bash
|
|
|
|
- name: Copy the CA certificate
|
|
copy:
|
|
src: "{{ ipsec_pki_path }}/cacert.pem"
|
|
dest: "{{ ipsec_config_path }}/manual/cacert.pem"
|
|
|
|
- name: Generate the serial number
|
|
shell: echo 01 > serial && touch serial_generated
|
|
args:
|
|
chdir: "{{ ipsec_pki_path }}"
|
|
creates: serial_generated
|
|
|
|
- name: Build the server pair
|
|
shell: >
|
|
umask 077;
|
|
{{ openssl_bin }} req -utf8 -new
|
|
-newkey ec:ecparams/secp384r1.pem
|
|
-config <(cat openssl.cnf <(printf "[basic_exts]\nsubjectAltName={{ subjectAltName }}"))
|
|
-keyout private/{{ IP_subject_alt_name }}.key
|
|
-out reqs/{{ IP_subject_alt_name }}.req -nodes
|
|
-passin pass:"{{ CA_password }}"
|
|
-subj "/CN={{ IP_subject_alt_name }}" -batch &&
|
|
{{ openssl_bin }} ca -utf8
|
|
-in reqs/{{ IP_subject_alt_name }}.req
|
|
-out certs/{{ IP_subject_alt_name }}.crt
|
|
-config <(cat openssl.cnf <(printf "[basic_exts]\nsubjectAltName={{ subjectAltName }}"))
|
|
-days 3650 -batch
|
|
-passin pass:"{{ CA_password }}"
|
|
-subj "/CN={{ IP_subject_alt_name }}" &&
|
|
touch certs/{{ IP_subject_alt_name }}_crt_generated
|
|
args:
|
|
chdir: "{{ ipsec_pki_path }}"
|
|
creates: certs/{{ IP_subject_alt_name }}_crt_generated
|
|
executable: bash
|
|
|
|
- name: Build the client's pair
|
|
shell: >
|
|
umask 077;
|
|
{{ openssl_bin }} req -utf8 -new
|
|
-newkey ec:ecparams/secp384r1.pem
|
|
-config <(cat openssl.cnf <(printf "[basic_exts]\nsubjectAltName={{ subjectAltName_USER }}"))
|
|
-keyout private/{{ item }}.key
|
|
-out reqs/{{ item }}.req -nodes
|
|
-passin pass:"{{ CA_password }}"
|
|
-subj "/CN={{ item }}" -batch &&
|
|
{{ openssl_bin }} ca -utf8
|
|
-in reqs/{{ item }}.req
|
|
-out certs/{{ item }}.crt
|
|
-config <(cat openssl.cnf <(printf "[basic_exts]\nsubjectAltName={{ subjectAltName_USER }}"))
|
|
-days 3650 -batch
|
|
-passin pass:"{{ CA_password }}"
|
|
-subj "/CN={{ item }}" &&
|
|
touch certs/{{ item }}_crt_generated
|
|
args:
|
|
chdir: "{{ ipsec_pki_path }}"
|
|
creates: certs/{{ item }}_crt_generated
|
|
executable: bash
|
|
with_items: "{{ users }}"
|
|
|
|
- name: Build the tests pair
|
|
shell: >
|
|
umask 077;
|
|
{{ openssl_bin }} req -utf8 -new
|
|
-newkey ec:ecparams/secp384r1.pem
|
|
-config <(cat openssl.cnf <(printf "[basic_exts]\nsubjectAltName=DNS:google-algo-test-pair.com"))
|
|
-keyout private/google-algo-test-pair.com.key
|
|
-out reqs/google-algo-test-pair.com.req -nodes
|
|
-passin pass:"{{ CA_password }}"
|
|
-subj "/CN=google-algo-test-pair.com" -batch &&
|
|
{{ openssl_bin }} ca -utf8
|
|
-in reqs/google-algo-test-pair.com.req
|
|
-out certs/google-algo-test-pair.com.crt
|
|
-config <(cat openssl.cnf <(printf "[basic_exts]\nsubjectAltName=DNS:google-algo-test-pair.com"))
|
|
-days 3650 -batch
|
|
-passin pass:"{{ CA_password }}"
|
|
-subj "/CN=google-algo-test-pair.com" &&
|
|
touch certs/google-algo-test-pair.com_crt_generated
|
|
args:
|
|
chdir: "{{ ipsec_pki_path }}"
|
|
creates: certs/google-algo-test-pair.com_crt_generated
|
|
executable: bash
|
|
when: tests|default(false)|bool
|
|
|
|
- name: Build openssh public keys
|
|
openssl_publickey:
|
|
path: "{{ ipsec_pki_path }}/public/{{ item }}.pub"
|
|
privatekey_path: "{{ ipsec_pki_path }}/private/{{ item }}.key"
|
|
format: OpenSSH
|
|
with_items: "{{ users }}"
|
|
|
|
- name: Get OpenSSL version
|
|
shell: |
|
|
set -o pipefail
|
|
{{ openssl_bin }} version |
|
|
cut -f 2 -d ' '
|
|
args:
|
|
executable: bash
|
|
register: ssl_version
|
|
run_once: true
|
|
|
|
- name: Set OpenSSL version fact
|
|
set_fact:
|
|
openssl_version: "{{ ssl_version.stdout }}"
|
|
|
|
- name: Build the client's p12
|
|
shell: >
|
|
umask 077;
|
|
{{ openssl_bin }} pkcs12
|
|
{{ (openssl_version is version('3', '>=')) | ternary('-legacy', '') }}
|
|
-in certs/{{ item }}.crt
|
|
-inkey private/{{ item }}.key
|
|
-export
|
|
-name {{ item }}
|
|
-out private/{{ item }}.p12
|
|
-passout pass:"{{ p12_export_password }}"
|
|
args:
|
|
chdir: "{{ ipsec_pki_path }}"
|
|
executable: bash
|
|
with_items: "{{ users }}"
|
|
register: p12
|
|
|
|
- name: Build the client's p12 with the CA cert included
|
|
shell: >
|
|
umask 077;
|
|
{{ openssl_bin }} pkcs12
|
|
{{ (openssl_version is version('3', '>=')) | ternary('-legacy', '') }}
|
|
-in certs/{{ item }}.crt
|
|
-inkey private/{{ item }}.key
|
|
-export
|
|
-name {{ item }}
|
|
-out private/{{ item }}_ca.p12
|
|
-certfile cacert.pem
|
|
-passout pass:"{{ p12_export_password }}"
|
|
args:
|
|
chdir: "{{ ipsec_pki_path }}"
|
|
executable: bash
|
|
with_items: "{{ users }}"
|
|
register: p12
|
|
|
|
- name: Copy the p12 certificates
|
|
copy:
|
|
src: "{{ ipsec_pki_path }}/private/{{ item }}.p12"
|
|
dest: "{{ ipsec_config_path }}/manual/{{ item }}.p12"
|
|
with_items:
|
|
- "{{ users }}"
|
|
|
|
- name: Get active users
|
|
shell: |
|
|
set -o pipefail
|
|
grep ^V index.txt |
|
|
grep -v "{{ IP_subject_alt_name }}" |
|
|
awk '{print $5}' |
|
|
sed 's/\/CN=//g'
|
|
args:
|
|
executable: /bin/bash
|
|
chdir: "{{ ipsec_pki_path }}"
|
|
register: valid_certs
|
|
|
|
- name: Revoke non-existing users
|
|
shell: >
|
|
{{ openssl_bin }} ca -gencrl
|
|
-config <(cat openssl.cnf <(printf "[basic_exts]\nsubjectAltName={{ subjectAltName_USER }}"))
|
|
-passin pass:"{{ CA_password }}"
|
|
-revoke certs/{{ item }}.crt
|
|
-out crl/{{ item }}.crt
|
|
register: gencrl
|
|
args:
|
|
chdir: "{{ ipsec_pki_path }}"
|
|
creates: crl/{{ item }}.crt
|
|
executable: bash
|
|
when: item.split('@')[0] not in users
|
|
with_items: "{{ valid_certs.stdout_lines }}"
|
|
|
|
- name: Generate new CRL file
|
|
shell: >
|
|
{{ openssl_bin }} ca -gencrl
|
|
-config <(cat openssl.cnf <(printf "[basic_exts]\nsubjectAltName=DNS:{{ IP_subject_alt_name }}"))
|
|
-passin pass:"{{ CA_password }}"
|
|
-out crl/algo.root.pem
|
|
when:
|
|
- gencrl is defined
|
|
- gencrl.changed
|
|
args:
|
|
chdir: "{{ ipsec_pki_path }}"
|
|
executable: bash
|
|
delegate_to: localhost
|
|
become: false
|
|
vars:
|
|
ansible_python_interpreter: "{{ ansible_playbook_python }}"
|
|
|
|
- name: Copy the CRL to the vpn server
|
|
copy:
|
|
src: "{{ ipsec_pki_path }}/crl/algo.root.pem"
|
|
dest: "{{ config_prefix|default('/') }}etc/ipsec.d/crls/algo.root.pem"
|
|
when:
|
|
- gencrl is defined
|
|
- gencrl.changed
|
|
notify:
|
|
- rereadcrls
|