mirror of
https://github.com/trailofbits/algo.git
synced 2025-09-23 04:13:20 +02:00
172fc348ef
* Add test to detect inline comments in Jinja2 expressions within YAML files
This test would have caught the bug reported where inline comments (#)
within Jinja2 expressions in YAML task files caused Ansible template
errors. The test:
- Extracts and validates all Jinja2 expressions from YAML files
- Specifically detects inline comments within {{ }} and {% %} blocks
- Includes regression test for the exact reported bug pattern
- Avoids false positives (# in strings, escaped #, comments outside expressions)
- Focuses on the critical inline comment issue
The original bug was in roles/strongswan/tasks/openssl.yml where comments
like "# Per-deployment UUID..." were placed inside a Jinja2 expression,
causing "unexpected char '#'" errors during playbook execution.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* Refactor test to use pytest framework and add comprehensive edge cases
- Converted standalone script to proper pytest test functions
- Replaced main() with individual test functions using pytest assertions
- Added comprehensive edge case tests for inline comment detection:
* Hash symbols in strings (should pass)
* Escaped hashes (should pass)
* Comments in control blocks (should fail)
* Multi-line expressions with comments (should fail)
* URL fragments and hex colors (should pass)
- Test functions now properly integrate with pytest:
* test_regression_openssl_inline_comments() - regression test
* test_edge_cases_inline_comments() - comprehensive edge cases
* test_yaml_files_no_inline_comments() - scan all YAML files
* test_openssl_file_specifically() - test the originally buggy file
This addresses the review feedback about pytest integration and adds
the suggested test cases for better coverage.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* Fix linter issues in test_yaml_jinja2_expressions.py
- Fixed trailing whitespace issues (W293)
- Applied ruff formatting for consistent code style
- All tests still pass after formatting changes
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* Add mutation testing guidance to CLAUDE.md
Added a section on writing effective tests that emphasizes the importance
of verifying that tests actually detect failure cases. This lightweight
mutation testing approach ensures:
- Tests catch the specific bugs they're designed to prevent
- We avoid false confidence from tests that always pass
- Test purposes are clear and documented
- Both success and failure cases are validated
The guidance includes a concrete example from our recent inline comment
detection test, showing how to verify both the problematic pattern
(should fail) and the fixed pattern (should pass).
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
|
||
|---|---|---|
| .. | ||
| test_basic_sanity.py | ||
| test_cloud_provider_configs.py | ||
| test_config_validation.py | ||
| test_docker_localhost_deployment.py | ||
| test_generated_configs.py | ||
| test_openssl_compatibility.py | ||
| test_strongswan_templates.py | ||
| test_template_rendering.py | ||
| test_user_management.py | ||
| test_wireguard_key_generation.py | ||
| test_yaml_jinja2_expressions.py | ||