wallenstein/iodine
1
0
Fork 0
mirror of https://github.com/yarrick/iodine.git synced 2025-06-05 02:03:43 +02:00
Code Issues Projects Releases Wiki Activity

Optimize putname function using out-of-bound while loop strlen()

Browse source 
My benchmarks here: https://github.com/yarrick/iodine/issues/110
This commit is contained in:
Herman Semenov 2025-04-09 00:49:42 +03:00
parent 2b65972693
commit 899f529d0c
No known key found for this signature in database
GPG key ID: D3AB1D2A4576D55E
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/read.c
View file

@ -158,7 +158,7 @@ int
putname(char **buf, size_t buflen, const char *host) putname(char **buf, size_t buflen, const char *host)
{ {
char *word; char *word;
int left; size_t left;
char *h; char *h;
char *p; char *p;
@ -167,18 +167,21 @@ putname(char **buf, size_t buflen, const char *host)
p = *buf; p = *buf;
word = strtok(h, "."); word = strtok(h, ".");
size_t len_word = strlen(word);
while(word) { while(word) {
if (strlen(word) > 63 || strlen(word) > left) { if (len_word > 63 || len_word > left) {
free(h); free(h);
return -1; return -1;
} }
left -= (strlen(word) + 1); len_word = strlen(word);
*p++ = (char)strlen(word); left -= len_word + 1;
memcpy(p, word, strlen(word)); *p++ = (char)len_word;
p += strlen(word); memcpy(p, word, len_word);
p += len_word;
word = strtok(NULL, "."); word = strtok(NULL, ".");
len_word = strlen(word);
} }
*p++ = 0; *p++ = 0;